This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): funnel chart improvements #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: force row_limit default value success by onInit function; 2: rm "show labels"; 3: rm label's textBorderColor; 4: rm "Funnel shape"; 5: rm "legend type"
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/4sTYANjJYc4dWMEuwpmsRf3xSZAk |
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 28.98% 28.99% +0.01%
==========================================
Files 462 462
Lines 9202 9204 +2
Branches 1449 1449
==========================================
+ Hits 2667 2669 +2
Misses 6333 6333
Partials 202 202
Continue to review full report at Codecov.
|
zhaoyongjie
changed the title
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
1: add
onInit functionto makerow_limitdefault value into effect1.1: before
1.2: after
2: rm
LABEL LINE2.1: before
2.2: after
3: rm label's textBorderColor
3.1: before
3.2: after
4: rm
Funnel shape4.1: rm Funnel shape before
4.1: rm Funnel shape after
5: rm
legend type5.1: before
5.2: after